git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] mailmap: avoid out-of-bounds memory access

From
Romain Francoise <romain@orebokech.com>
Date
Oct 28, 2012, 13:21 UTC
Message-ID
<87k3ua3f6q.fsf@silenus.orebokech.com>
In-Reply-To
<20121028110207.GA11434@sigill.intra.peff.net>
Jeff King <peff@peff.net> writes:
> So you could also check for "left == nstart" before the loop even
> begins. I think your fix (to just make the loop more robust to that
> precondition) is better, though, as the rest of the code does the right
> thing with such a value of nend.
Yep.
> It looks like t4203 triggers this problem. Curious that valgrind does
> not find it. I guess since it does not have compiler support, it cannot
> find out-of-bound errors on stack buffers. Does the rest of the test
> suite turn up clean with AddressSanitizer?

I tested your 'master' and your 'pu' with expensive tests enabled and both are clean after fixing t4203.

Thanks!
Previous: Jeff King
Message 3 of 3 in “mailmap: avoid out-of-bounds memory access”
  1. mailmap: avoid out-of-bounds memory accessRomain Francoise, Oct 27, 2012
  2. Jeff KingOct 28, 2012
  3. Romain FrancoiseOct 28, 2012

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.