From: Romain Francoise <romain@orebokech.com>
Date: Sun, 28 Oct 2012 13:21:33 GMT
Subject: Re: [PATCH] mailmap: avoid out-of-bounds memory access
Message-ID: <87k3ua3f6q.fsf@silenus.orebokech.com>
In-Reply-To: <20121028110207.GA11434@sigill.intra.peff.net>

Jeff King <peff@peff.net> writes:

> So you could also check for "left == nstart" before the loop even
> begins. I think your fix (to just make the loop more robust to that
> precondition) is better, though, as the rest of the code does the right
> thing with such a value of nend.

Yep.

> It looks like t4203 triggers this problem. Curious that valgrind does
> not find it. I guess since it does not have compiler support, it cannot
> find out-of-bound errors on stack buffers. Does the rest of the test
> suite turn up clean with AddressSanitizer?

I tested your 'master' and your 'pu' with expensive tests enabled and both
are clean after fixing t4203.

Thanks!