git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: git-subtree

From
David A. Greene <greened@obbligato.org>
Date
Jan 5, 2012, 15:03 UTC
Message-ID
<87ipkq199w.fsf@smith.obbligato.org>
In-Reply-To
<CALkWK0nU9iO_6CCbWw8c_Fz=xodkaAW4300Jpc7M7D+kBP=QRg@mail.gmail.com>
Ramkumar Ramachandra <artagnon@gmail.com> writes:
Show 11 quoted lines
> Hi David,
>
> David Greene wrote:
>> I have a patch ready.
>> How does the git community want the patch presented?
>
> Please read and follow the guidelines listed in
> Documentation/SubmittingPatches.  The TL;DR version is: break it up
> into logical reviewable commits based on the current `master` and use
> git format-patch/ git send-email to send those commits to this mailing
> list.

I've read that document. The issue is that I didn't develop the code, Avery did. This is a completely new tool for git and I don't have the first idea of what "logical" chunks would look like. I assume, for example, that we'd want the first "chunk" to actually work and do something interesting. I can go spend a bunch of time to see if I can grok enough to create these chunks but I wanted to check first and make sure that would be absolutely necessary. It's a lot of time to learn a completely new codebase. I was hoping to submit something soon and then learn the codebase gradually during maintenance/further development.

How have completely new tools be introduced into the git mainline in the past?

Thanks!
                              -Dave
Previous: Ramkumar RamachandraNext: Ramkumar Ramachandra
Message 3 of 15 in “git-subtree”
  1. David GreeneJan 4, 2012
  2. Ramkumar RamachandraJan 5, 2012
  3. David A. GreeneJan 5, 2012
  4. Ramkumar RamachandraJan 5, 2012
  5. David A. GreeneJan 5, 2012
  6. David A. GreeneJan 6, 2012
  7. David A. GreeneJan 5, 2012
  8. Jeff KingJan 5, 2012
  9. David A. GreeneJan 5, 2012
  10. David A. GreeneJan 29, 2012
  11. David A. GreeneJan 30, 2012
  12. David A. GreeneJan 5, 2012
  13. Junio C HamanoJan 5, 2012
  14. David A. GreeneJan 5, 2012
  15. David A. GreeneJan 5, 2012

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.