Re: Bug: pull --rebase with é in name

From: Thomas Rast <trast@inf.ethz.ch>
Date: Mar 5, 2012, 13:04 UTC
Message-ID: <87ipijkxlm.fsf@thomas.inf.ethz.ch>
In-Reply-To: <0E2B8DE3-1ABD-453F-BCAA-0D693ECA5987@habr.de>

René Haber <rene@habr.de> writes:

Show 7 quoted lines

> sh -c '                                   
>    . /sw/lib/git-core/git-sh-setup
>     get_author_ident_from_commit 16b94413cbce12531e8f946286851598449d3913
>  '
> GIT_AUTHOR_NAME='Ren'é Haber
> GIT_AUTHOR_EMAIL='rene@habr.de'
> GIT_AUTHOR_DATE='@1329212923 +0100'

I think this is the same issue that we recently discussed on #git-devel, where some broken versions of sed will fail to match "any character" with '.' even under LC_ALL=C. Will "shruggar" Palmer (cc) had this issue under OS X with a build of GNU sed that ignored LC_*.

You can verify that this is the problem by looking at

  printf "\370\235\204\236\n" | LC_CTYPE=C sed 's/./x/g' | xxd

It should say

  0000000: 7878 7878 0a                             xxxx.

That is, the garbage (if you try to read it as UTF-8) in the printf string was matched and replaced byte-by-byte with 'x'. However, Will was getting the unreplaced results

  0000000: f89d 849e 0a                             .....

I'm not sure he has followed up on that problem; the only hope may be to get a better 'sed'.

-- 
Thomas Rast
trast@{inf,student}.ethz.ch