Re: Bug: pull --rebase with é in name

From: Thomas Rast <trast@inf.ethz.ch>
Date: Mar 6, 2012, 08:36 UTC
Message-ID: <87399mazxs.fsf@thomas.inf.ethz.ch>
In-Reply-To: <7v8vjf2c8o.fsf@alter.siamese.dyndns.org>

Junio C Hamano <gitster@pobox.com> writes:

Show 13 quoted lines

> Jeff King <peff@peff.net> writes:
>
>> It would be nice if the --pretty format placeholders had a "shell-quote"
>> modifier, and we could just do:
>>
>>   git show --format='GIT_AUTHOR_NAME=%(an:shell)'
>>
>> or something similar. for-each-ref knows about shell-quoting, but we
>> can't use it here, because we are looking at arbitrary commits, not just
>> ones pointed to by refs.
>
> You guys seem to have been having a lot of fun overnight. Perhaps I
> should live on European time?

IIUC Peff just got up at an unreasonably early time to have fun with us Europeans?

Show 12 quoted lines

> I think there were talks about cross pollinating and eventually
> unifying the placeholder languages of pretty and for-each-ref, and
> if we were to do so, I agree that --pretty definitely should learn
> to do --sq. But I do not think we want to teach everything :shell;
> following the style of %w(), something more generic that would apply
> to any payload would be preferred, perhaps giving an end result like
> this:
>
> 	git show -s --format='
> 		GIT_AUTHOR_NAME=%(sq-begin)%an%(sq-end)
>                 GIT_AUTHOR_EMAIL=%(sq-begin)%ae%(sq-end)
>         '

How about something along the lines of %Q(%an) instead? Though at least implementation-wise, it should be possible to make %'%an%' work, too, which would be rather cute.

Show 5 quoted lines

> In any case, my reading of the conclusion you guys have already
> reached in this thread is that the issue is not even a bug in Git,
> but is a broken build/installation of sed by a third-party.  I am
> inclined to suggest any change to get_author_ident_from_commit
> helper backburnered before we teach --sq to --pretty machinery.

Ok.

This is the second "victim" of this broken install of sed, however. I wonder where René and Will got it from? Perhaps this is "the" common way of getting GNU sed on OS X, and thus more widespread than we might think.

-- 
Thomas Rast
trast@{inf,student}.ethz.ch