git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 1/2] builtin/blame.c: struct blame_entry does not need a prev link

From
David Kastrup <dak@gnu.org>
Date
Jan 21, 2014, 23:02 UTC
Message-ID
<87eh41os4q.fsf@fencepost.gnu.org>
In-Reply-To
<xmqqlhy9t2z1.fsf@gitster.dls.corp.google.com>
Junio C Hamano <gitster@pobox.com> writes:
Show 10 quoted lines
> David Kastrup <dak@gnu.org> writes:
>
>> ---
>
> Thanks.  At some point during its development I must have thought
> that having it as a dual-linked list may make it easier when we have
> to split a block into pieces, but it seems that split_overlap() does
> not need to look at this information.
>
> Needs sign-off.

Well, as I said: it's quite possible that the double-linking might be useful for some particular hypothetical rewrite of the code. It isn't for the current code, and it's not useful for my own rewrite.

Will be posting a signed-off version presently.
-- 
David Kastrup
Previous: Junio C HamanoNext: David Kastrup
Message 4 of 17 in “Two janitorial patches for builtin/blame.c”
  1. 0/2 Two janitorial patches for builtin/blame.cDavid Kastrup, Jan 19, 2014
  2. 1/2 builtin/blame.c: struct blame_entry does not need a prev linkDavid Kastrup, Jan 19, 2014
  3. Junio C HamanoJan 21, 2014
  4. David KastrupJan 21, 2014
  5. 2/2 Eliminate same_suspect function in builtin/blame.cDavid Kastrup, Jan 19, 2014
  6. David KastrupJan 21, 2014
  7. Jonathan NiederJan 21, 2014
  8. David KastrupJan 21, 2014
  9. Jonathan NiederJan 21, 2014
  10. David KastrupJan 21, 2014
  11. Jonathan NiederJan 21, 2014
  12. David KastrupJan 21, 2014
  13. Jonathan NiederJan 21, 2014
  14. David KastrupJan 21, 2014
  15. Junio C HamanoJan 21, 2014
  16. David KastrupJan 21, 2014
  17. Jonathan NiederJan 21, 2014

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.