git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 0/2] Two janitorial patches for builtin/blame.c

From
David Kastrup <dak@gnu.org>
Date
Jan 21, 2014, 16:22 UTC
Message-ID
<87d2jlqp7x.fsf@fencepost.gnu.org>
In-Reply-To
<1390157870-29795-1-git-send-email-dak@gnu.org>
David Kastrup <dak@gnu.org> writes:
> This is more a warmup than anything else: I'm actually doing a quite
> more involved rewrite of git-blame right now.  But it's been a long
> time since I sent patches for Git, so I'm starting out with something
> reasonably uncontroversial.
Ping?

Now I might have sent at an unopportune time: blame.c is mostly attributed to Junio who seems to have been a few days absent now.

I also have seen quite a few mails and patch submissions on the list go basically unanswered in the last few days.

So it might just be that this is business as usual. However, since I have not been on this list for quite a while, I would want to avoid causing large delays by some oversight.

I have not so far signed off on the patches: it would appear that this is required. The submission guidelines in Documentation/SubmittingPatches state for signing off:

        (a) The contribution was created in whole or in part by me and I
            have the right to submit it under the open source license
            indicated in the file; or
[...]
        (d) I understand and agree that this project and the contribution
            are public and that a record of the contribution (including all
            personal information I submit with it, including my sign-off) is
            maintained indefinitely and may be redistributed consistent with
            this project or the open source license(s) involved.

Now the file involved (builtin/blame.c) itself does not state _any_ license. Instead it states

    /*
     * Blame
     *
     * Copyright (c) 2006, Junio C Hamano
     */

I do not intend my contribution to constitute a copyright assignment (and it hardly could be one). The top file COPYING in Git states

     Note that the only valid version of the GPL as far as this project
     is concerned is _this_ particular version of the license (ie v2, not
     v2.2 or v3.x or whatever), unless explicitly otherwise stated.
     HOWEVER, in order to allow a migration to GPLv3 if that seems like
     a good idea, I also ask that people involved with the project make
     their preferences known. In particular, if you trust me to make that
     decision, you might note so in your copyright message, ie something
     like
            This file is licensed under the GPL v2, or a later version
            at the discretion of Linus.
      might avoid issues. But we can also just decide to synchronize and
      contact all copyright holders on record if/when the occasion arises.

As far as I am concerned, I am willing to license my work under the GPLv2 or any later version at the discretion of whoever wants to work with it. I think that should be compatible with the project goals.

Now the above passage states "you might note so in your copyright message", but my patches do not even contain a copyright message and it is not clear to me that they should, or that there is a sensible place to place such "copyright messages".

So any guidance about that?
-- 
David Kastrup
Previous: David KastrupNext: Jonathan Nieder
Message 6 of 17 in “Two janitorial patches for builtin/blame.c”
  1. 0/2 Two janitorial patches for builtin/blame.cDavid Kastrup, Jan 19, 2014
  2. 1/2 builtin/blame.c: struct blame_entry does not need a prev linkDavid Kastrup, Jan 19, 2014
  3. Junio C HamanoJan 21, 2014
  4. David KastrupJan 21, 2014
  5. 2/2 Eliminate same_suspect function in builtin/blame.cDavid Kastrup, Jan 19, 2014
  6. David KastrupJan 21, 2014
  7. Jonathan NiederJan 21, 2014
  8. David KastrupJan 21, 2014
  9. Jonathan NiederJan 21, 2014
  10. David KastrupJan 21, 2014
  11. Jonathan NiederJan 21, 2014
  12. David KastrupJan 21, 2014
  13. Jonathan NiederJan 21, 2014
  14. David KastrupJan 21, 2014
  15. Junio C HamanoJan 21, 2014
  16. David KastrupJan 21, 2014
  17. Jonathan NiederJan 21, 2014

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.