git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: Please default to 'commit -a' when no changes were added

From
GBGoswin von Brederlow <goswin-v-b@web.de>
Date
Apr 23, 2010, 14:23 UTC
Message-ID
<87bpdamem8.fsf@frosties.localdomain>
In-Reply-To
<20100423093943.GB30346@atjola.homenet>
Björn Steinbrink <B.Steinbrink@gmx.de> writes:
Show 17 quoted lines
> On 2010.04.22 22:37:05 +0200, Goswin von Brederlow wrote:
>> Is there a risk? You do get an editor with all the files affected listed
>> giving you a big fat warning what you are about to commit.
>
> And if I happen to have two unrelated changes in a single file that's
> worth nothing at all. For example, I might have changed the condition
> that causes some message to be shown, and discovered a typo in the
> message itself and fixed it along the way. That needs two commits, but
> the list of modified files doesn't tell that.
>
> Only "commit -v" would help there, showing the diff in the editor. But
> reviewing the diff in the editor is a PITA and I lose the whole review
> progress if I find something I don't want to commit and have to abort.
> Using "git add [-i|-p|-e]", git helps me to keep track of the changes I
> already reviewed and decided to commit.
>
> Björn

Then you would keep doing that or use git commit --interactive. The suggested change would not affect you at all either way.

MfG
        Goswin
Previous: Sergei OrganovNext: Matthias Andree
Message 42 of 76 in “Re: Please default to 'commit -a' when no changes were added”
  1. Jonathan NiederApr 22, 2010
  2. Goswin von BrederlowApr 22, 2010
  3. Nicolas PitreApr 22, 2010
  4. Sverre RabbelierApr 22, 2010
  5. Goswin von BrederlowApr 22, 2010
  6. Nicolas PitreApr 22, 2010
  7. Goswin von BrederlowApr 23, 2010
  8. Miles BaderApr 23, 2010
  9. Wincent ColaiutaApr 23, 2010
  10. Goswin von BrederlowApr 23, 2010
  11. Michael WittenApr 23, 2010
  12. Daniel GraceApr 23, 2010
  13. Nicolas PitreApr 23, 2010
  14. Goswin von BrederlowApr 24, 2010
  15. Jonathan NiederApr 24, 2010
  16. Goswin von BrederlowApr 24, 2010
  17. Jonathan NiederApr 24, 2010
  18. Miles BaderApr 25, 2010
  19. Jonathan NiederApr 25, 2010
  20. Matthias AndreeApr 23, 2010
  21. Junio C HamanoApr 24, 2010
  22. Junio C HamanoApr 22, 2010
  23. Matthieu MoyApr 22, 2010
  24. Michael WittenApr 22, 2010
  25. Goswin von BrederlowApr 23, 2010
  26. Tomas CarneckyApr 23, 2010
  27. Michael WittenApr 23, 2010
  28. Matthieu MoyApr 23, 2010
  29. Tor ArntsenApr 23, 2010
  30. Adam BrewsterApr 22, 2010
  31. Jonathan NiederApr 22, 2010
  32. Goswin von BrederlowApr 23, 2010
  33. The index (Re: Please default to 'commit -a' when no changes were added)Jonathan Nieder, Apr 23, 2010
  34. Jon SeymourApr 22, 2010
  35. Adam BrewsterApr 23, 2010
  36. Goswin von BrederlowApr 23, 2010
  37. Goswin von BrederlowApr 23, 2010
  38. Björn SteinbrinkApr 23, 2010
  39. Sergei OrganovApr 23, 2010
  40. Sverre RabbelierApr 23, 2010
  41. Sergei OrganovApr 23, 2010
  42. Goswin von BrederlowApr 23, 2010
  43. Matthias AndreeApr 23, 2010
  44. Michael WittenApr 23, 2010
  45. Matthias AndreeApr 23, 2010
  46. Eric RaymondApr 23, 2010
  47. Michael WittenApr 23, 2010
  48. Eric RaymondApr 24, 2010
  49. Michael WittenApr 24, 2010
  50. Eric RaymondApr 24, 2010
  51. Michael WittenApr 23, 2010
  52. Tor ArntsenApr 24, 2010
  53. 'commit -a' safety (was: Re: Please default to 'commit -a' when no changes were added)Jakub Narebski, Apr 24, 2010
  54. Miles BaderApr 24, 2010
  55. Andreas SchwabApr 24, 2010
  56. Jakub NarebskiApr 24, 2010
  57. Miles BaderApr 24, 2010
  58. Nicolas PitreApr 24, 2010
  59. Jakub NarebskiApr 25, 2010
  60. Miles BaderApr 25, 2010
  61. Wincent ColaiutaApr 24, 2010
  62. Jakub NarebskiApr 24, 2010
  63. Joey HessApr 24, 2010
  64. Mike HommeyApr 24, 2010
  65. Petr BaudisApr 24, 2010
  66. Bug#578764: 'commit -a' safety (was: Re: Please default to 'commit -a' when no changes were added)Wincent Colaiuta, Apr 24, 2010
  67. Petr BaudisApr 24, 2010
  68. Nicolas PitreApr 24, 2010
  69. Petr BaudisApr 24, 2010
  70. Nicolas PitreApr 24, 2010
  71. Jacob HelwigApr 24, 2010
  72. Nicolas PitreApr 24, 2010
  73. Jacob HelwigApr 24, 2010
  74. Jakub NarebskiApr 24, 2010
  75. Junio C HamanoApr 25, 2010
  76. Jakub NarebskiApr 25, 2010

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.