Re: Please default to 'commit -a' when no changes were added

From: Junio C Hamano <gitster@pobox.com>
Date: Apr 24, 2010, 01:43 UTC
Message-ID: <7vwrvxtyjm.fsf@alter.siamese.dyndns.org>
In-Reply-To: <87aastx6sa.fsf@frosties.localdomain>

Goswin von Brederlow <goswin-v-b@web.de> writes:

> But you are already rejecting it in the design phase before there even
> is a patch.

We do review both the design and the implementation on this list, and it actually is a *good* thing if a proposal is rejected when its design is flawed at the conceptual level.

A perfect implementation of an undesirable design is just as undesirable as a buggy implementation of the same design. It is a change that we do not want to have in the system.

As to this particular proposed change to commit everything only when there is no change between the index and the HEAD, I think it is a bad change. As several people have already said, it adds unnecessary complexity to the end user's mental model.