Re: [PATCH] Add contrib/credentials/netrc with GPG support, try #2

From: Ted Zlatanov <tzz@lifelogs.com>
Date: Feb 5, 2013, 20:03 UTC
Message-ID: <87bobyr0ju.fsf@lifelogs.com>
In-Reply-To: <7vip66sftf.fsf@alter.siamese.dyndns.org>

On Tue, 05 Feb 2013 11:47:56 -0800 Junio C Hamano <gitster@pobox.com> wrote:

JCH> Ted Zlatanov <tzz@lifelogs.com> writes: JCH> Oh, another thing. 'default' is like 'machine' followed by any JCH> machine name, so the above while loop that reads two tokens JCH> pair-wise needs to be aware that 'default' is not followed by a JCH> value. I think the loop will fail to parse this:

>>

JCH> default login anonymous password me@home JCH> machine k.org login me password mysecret

>> 
>> I'd prefer to ignore "default" because it should not be used for the Git
>> credential helpers (its only use case is for anonymous services AFAIK).
>> So I'll add a case to ignore it in PATCHv4, if that's OK.

JCH> You still need to parse a file that has a "default" entry correctly; JCH> otherwise the users won't be able to share existing .netrc files JCH> with other applications e.g. ftp, which is the whole point of this JCH> series. Not using values from the "default" entry is probably fine, JCH> though.

OK; done in PATCHv4.

Ted