Re: [PATCH] Add contrib/credentials/netrc with GPG support, try #2

From: Junio C Hamano <gitster@pobox.com>
Date: Feb 5, 2013, 00:15 UTC
Message-ID: <7vmwvjzkcs.fsf@alter.siamese.dyndns.org>
In-Reply-To: <87zjzjr5y4.fsf@lifelogs.com>

Ted Zlatanov <tzz@lifelogs.com> writes:

Show 15 quoted lines

> On Mon, 04 Feb 2013 15:40:32 -0800 Junio C Hamano <gitster@pobox.com> wrote: 
>
> JCH> "Sorry we couldn't" sounded like an error messag to me.  If this is
> JCH> a normal exit, then please make sure it is a normal exit.
>
> OK; done in PATCHv4: removed all "Sorry" because they are not abnormal
> exits.  I'll hold PATCHv4 until the below are known.
>
> JCH> The review cycle is not like reviewers give you instructions and
> JCH> designs and you blindly implement them.  It is a creative process
> JCH> where you show the design and a clear implementation of that design.
>
> OK.  I would like you to make the decisions I asked for, though:
>
> - do you want to support backslashed newlines?

What for? netrc/authinfo is not a line oriented file format at all, and

	machine k.org
	        	login me
                        password mysecret

is a single entry; you do not need backslash at the end of any line.

Perhaps you are asking something different?

> - do you want me to remove the statement modifiers?

I do not think we are at that "implementation nitpick" level yet.

> - should all die() calls just print to STDERR and exit(0)?

Where "when unhandled, the helper should silently exit with 0" is expected by the invoker, we shouldn't say anything to error stream, and exit with zero. Please leave a comment to make it easy to understand to the readers that is what is going on there.

If on the other hand it diagnosed an error (not a bug in the implementation but a misconfiguration on the user's side), I _think_ it should loudly die() so that the user can notice and take corrective action.

> - do you want to support multiple netrc files, as you and Peff suggested?

I didn't even suggest such thing IIRC---I expected it to iterate from the most desirable (.authinfo.gpg) to the least (.netrc) and stop at the first found one. There may be use cases people use more than one and expect an entry to be found in any file, but I suspect that might be more confusing than it is worth. But I do not care very deeply myself either way.