Re: [PATCH 08/10] receive-pack: convert 'update' hook to hook.h

> On Thu, Sep 25, 2025 at 5:54 AM Adrian Ratiu 
> <adrian.ratiu@collabora.com> wrote: 
>> 
>> From: Emily Shaffer <emilyshaffer@google.com> 
>> 
>> This makes use of the new sideband API in hook.h added in the 
>> preceding commit. 
>> 
>> Signed-off-by: Emily Shaffer <emilyshaffer@google.com> 
>> Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com> --- 
>>  builtin/receive-pack.c | 60 
>>  +++++++++++++++++++++++++++++------------- 1 file changed, 41 
>>  insertions(+), 19 deletions(-) 
>> 
>> diff --git a/builtin/receive-pack.c b/builtin/receive-pack.c 
>> index 1113137a6f..d5192ce132 100644 --- 
>> a/builtin/receive-pack.c +++ b/builtin/receive-pack.c @@ 
>> -939,31 +939,53 @@ static int run_receive_hook(struct command 
>> *commands, 
>>         return status; 
>>  } 
>> 
>> -static int run_update_hook(struct command *cmd) +static void 
>> hook_output_to_sideband(struct strbuf *output, void *cb_data 
>> UNUSED) 
>>  { 
>> -       struct child_process proc = CHILD_PROCESS_INIT; - 
>> int code; -       const char *hook_path = 
>> find_hook(the_repository, "update"); +       int 
>> keepalive_active = 0; 
>> 
>> -       if (!hook_path) -               return 0; +       if 
>> (keepalive_in_sec <= 0) +               use_keepalive = 
>> KEEPALIVE_NEVER; +       if (use_keepalive == KEEPALIVE_ALWAYS) 
>> +               keepalive_active = 1; 
> 
> This hook wasn't using the keepalive at all before, right? 
> What's the reason to use it now? I am worried it might be going 
> to a sideband consumer who wasn't expecting it because it's not 
> documented in githooks.