Re: [PATCH v2 10/10] receive-pack: convert receive hooks to hook API

From: Adrian Ratiu <adrian.ratiu@collabora.com>
Date: Oct 29, 2025, 13:46 UTC
Message-ID: <87bjlp7rcd.fsf@gentoo.mail-host-address-is-not-set>
In-Reply-To: <b03a96a8-af42-427a-8cf1-4d195be6a7c7@app.fastmail.com>

On Tue, 28 Oct 2025, "Kristoffer Haugsbakk" <kristofferhaugsbakk@fastmail.com> wrote:

Show 14 quoted lines

> On Fri, Oct 17, 2025, at 16:15, Adrian Ratiu wrote: 
>> From: Emily Shaffer <emilyshaffer@google.com> 
>> 
>> This converts the last remaining hooks to the new hook API, for 
>> the same benefits as the previous conversions (no need to 
>> toggle signals, manage custom struct child_process, call 
>> find_hook(), prepares for specifyinig hooks via configs, etc.). 
>> 
>> I noticed a performance degradation when processing large 
>> amounts of hook input with just 1 line per callback, due to 
>> run-command's ppoll loop, therefore I batched 500 lines per 
>> callback, to ensure 
> 
> I don’t see `ppoll` in `run-command.c`.

Good point, it's poll not ppoll. :)

(The while(1) loop in run_processes_parallel() from run-command.c calls pp_buffer_stderr() then poll with an output_timeout of 100).

I will fix this together with the other typos you pointed out in v3.

Thank you, Adrian