Re: misleading diff-hunk header

From: Thomas Rast <trast@student.ethz.ch>
Date: Aug 21, 2012, 15:22 UTC
Message-ID: <87a9xoi82i.fsf@thomas.inf.ethz.ch>
In-Reply-To: <503385D0.5070605@tim.thechases.com>

Tim Chase <git@tim.thechases.com> writes:

> diff.{type}.xfuncname seems to start searching backwards in
> from the beginning of the hunk, not the first differing line.

[...]

Show 9 quoted lines

>   @@ -4,4 +4,5 @@ int call_me(int maybe)
>
>    int main()
>    {
>   +  return 0;
>    }
>
> misleadingly suggesting that the change occurred in the call_me()
> function, rather than in main()

I think that's intentional, and matches what 'diff -p' does. It gives you the context before the hunk. After all, if a new function starts in the leading context lines, you can see that in the usual diff data.

-- 
Thomas Rast
trast@{inf,student}.ethz.ch