Re: misleading diff-hunk header

From: Tim Chase <git@tim.thechases.com>
Date: Aug 25, 2012, 12:56 UTC
Message-ID: <5038CB66.1040006@tim.thechases.com>
In-Reply-To: <7va9xjy4or.fsf@alter.siamese.dyndns.org>

On 08/24/12 23:29, Junio C Hamano wrote:

Show 9 quoted lines

> Tim Chase <git@tim.thechases.com> writes:
>> If the documented purpose of "diff -p" (and by proxy
>> diff.{type}.xfuncname) is to show the name of the *function*
>> containing the changed lines,....
> 
> Yeah, the documentation is misleading, but I do not offhand think of
> a better phrasing. Perhaps you could send in a patch to improve it.
> 
> How does GNU manual explain the option?

Tersely. :-)

       -p  --show-c-function
              Show which C function each change is in.

And that's it. To describe the current behavior, it might be better written as "Find and show the first function definition prior to the hunk". The code in diff(1) actually just uses the regexp something like "^[a-z]" which happens to find function definitions, but can also find module-level variable definitions, structs, etc.

-tkc