Re: [PATCH] clone: the given repository dir should be relative to $PWD

From: Yasushi SHOJI <yashi@atmark-techno.com>
Date: Oct 15, 2006, 03:09 UTC
Message-ID: <878xjiqnq7.wl@mail2.atmark-techno.com>
In-Reply-To: <7v7iz274zy.fsf@assigned-by-dhcp.cox.net>

At Sat, 14 Oct 2006 18:16:33 -0700, Junio C Hamano wrote:

Show 23 quoted lines

> 
> Yasushi SHOJI <yashi@atmark-techno.com> writes:
> 
> > the repository argument for git-clone should be relative to $PWD
> > instead of the given target directory.  The old behavior gave us
> > surprising success and you need a few minute to know why it worked.
> >
> > GIT_DIR is already exported so no need to cd into $D. And this makes
> > $PWD for git-fetch-pack, which is the actual command to take the given
> > repository dir, the same as git-clone.
> >
> > Signed-off-by: Yasushi SHOJI <yashi@atmark-techno.com>
> > ---
> >
> > While I'm not sure this is a feature we rely on or not, and I don't
> > want to change the way people work, IMHO the old behaviour isn't
> > appropriate for such higher level porcelain.
> >
> > The patch should be for post 1.4.3.
> 
> Well spotted.  I am fairly sure that this "clone from repository
> relative to the target" is not intended behaviour.  I'd say we
> should fix this before 1.4.3.

OK. if the behavior isn't intended and there ain't much user for it, I don't have any reason not to. my last sentence was more like a question to you rather than my statement.

let's fix it before 1.4.3.

> ... or are there any valid reason to keep the current behaviour
> that I missed?

I don't think so. I personally consider the behavior a bug. I just thought that we don't want to have user saying "hey, v1.4.3 doesn't work any more!" report, given that we are already in -rc2.

-- 
          yashi