Re: [PATCH] clone: the given repository dir should be relative to $PWD

From: Junio C Hamano <junkio@cox.net>
Date: Oct 15, 2006, 01:16 UTC
Message-ID: <7v7iz274zy.fsf@assigned-by-dhcp.cox.net>
In-Reply-To: <87ac3zqebs.wl@mail2.atmark-techno.com>

Yasushi SHOJI <yashi@atmark-techno.com> writes:

Show 16 quoted lines

> the repository argument for git-clone should be relative to $PWD
> instead of the given target directory.  The old behavior gave us
> surprising success and you need a few minute to know why it worked.
>
> GIT_DIR is already exported so no need to cd into $D. And this makes
> $PWD for git-fetch-pack, which is the actual command to take the given
> repository dir, the same as git-clone.
>
> Signed-off-by: Yasushi SHOJI <yashi@atmark-techno.com>
> ---
>
> While I'm not sure this is a feature we rely on or not, and I don't
> want to change the way people work, IMHO the old behaviour isn't
> appropriate for such higher level porcelain.
>
> The patch should be for post 1.4.3.

Well spotted. I am fairly sure that this "clone from repository relative to the target" is not intended behaviour. I'd say we should fix this before 1.4.3.

... or are there any valid reason to keep the current behaviour that I missed?