git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] mailmap: fix check for freeing memory

From
Thomas Rast <trast@inf.ethz.ch>
Date
Aug 20, 2013, 13:40 UTC
Message-ID
<878uzw7a6l.fsf@linux-k42r.v.cablecom.net>
In-Reply-To
<1377004958-14489-1-git-send-email-stefanbeller@googlemail.com>
Stefan Beller <stefanbeller@googlemail.com> writes:
> The condition as it is written in that line was most likely intended to
> check for the pointer passed to free(), rather than checking for the
> 'repo_abbrev', which is already checked against being non null at the
> beginning of the function.
[...]
> -			if (repo_abbrev)
> +			if (*repo_abbrev)
>  				free(*repo_abbrev);

But now the test is useless, because free(NULL) is defined to be a no-op.

-- 
Thomas Rast
trast@{inf,student}.ethz.ch
Previous: Stefan BellerNext: Jeff King
Message 2 of 12 in “mailmap: fix check for freeing memory”
  1. mailmap: fix check for freeing memoryStefan Beller, Aug 20, 2013
  2. Thomas RastAug 20, 2013
  3. Jeff KingAug 20, 2013
  4. Stefan BellerAug 20, 2013
  5. mailmap: remove redundant check for freeing memoryStefan Beller, Aug 20, 2013
  6. Jeff KingAug 20, 2013
  7. Thomas RastAug 20, 2013
  8. Stefan BellerAug 20, 2013
  9. Jeff KingAug 20, 2013
  10. Junio C HamanoAug 20, 2013
  11. Jeff KingAug 20, 2013
  12. Jeff KingAug 20, 2013

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.