Re: [PATCH] mailmap: fix check for freeing memory

From: Jeff King <peff@peff.net>
Date: Aug 20, 2013, 17:45 UTC
Message-ID: <20130820174505.GA10106@sigill.intra.peff.net>
In-Reply-To: <xmqqob8s7033.fsf@gitster.dls.corp.google.com>

On Tue, Aug 20, 2013 at 10:18:08AM -0700, Junio C Hamano wrote:

Show 9 quoted lines

> As you mentioned, merge gives readable merge log messages, but it
> deliberately uses the real URL, not your personal nickname for the
> remote when writing the title line of a merge, i.e.
> 
> 	Merge [branch <x> of ]<repoURL>
> 
> so it would be helped by the repository abbreviation.  It probably
> was an oversight that we did not extend it to the rest of the log
> family.

Ah, yeah, I suppose git-pull will still do that. I was thinking of a direct git-merge of a tracking branch, which would end up with:

  Merge remote-tracking branch 'origin/master'

whereas "git pull origin master" in the same case would say:

  Merge branch 'master' of git://github.com/gitster/git

Still, I do not think anybody but the kernel is using it. Most people simply have shorter URLs that do not need abbreviated (e.g., the GitHub one shown above). And searching for instances on GitHub yields only the kernel:

  https://github.com/search?q=repo-abbrev+path%3A.mailmap&type=Code

Anyway, I am not proposing ripping the feature out. It just seems like it does not have a lot of users, and it is not worth worrying much about trying to extend it.

-Peff