git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] xdiff: load full words in the inner loop of xdl_hash_record

From
Thomas Rast <trast@inf.ethz.ch>
Date
Mar 12, 2012, 20:13 UTC
Message-ID
<877gypr319.fsf@thomas.inf.ethz.ch>
In-Reply-To
<7vmx7lsmjd.fsf@alter.siamese.dyndns.org>
Junio C Hamano <gitster@pobox.com> writes:
Show 9 quoted lines
> Thomas Rast <trast@student.ethz.ch> writes:
>
>> Also definitely post-v1.7.10 material, but I figure many people will
>> be interested.  Since it's such a central part of much of git, it's
>> also quite important that it gets tested heavily.
>
> I am interested but this is a material not beyond 'pu'.  Until it
> learns to be nice on platforms that do not like unaligned accesses
> or use big endian, that is.

Umm, nice how? It leaves in the old version for those platforms. I can perhaps make it #error if we are unhappy about the user's platform, but that's about it. Testing for endianness is possible, but testing for unaligned access risks SIGBUS and thus requires spawning a helper program.

-- 
Thomas Rast
trast@{inf,student}.ethz.ch
Previous: Junio C HamanoNext: Junio C Hamano
Message 3 of 4 in “xdiff: load full words in the inner loop of xdl_hash_record”
  1. xdiff: load full words in the inner loop of xdl_hash_recordThomas Rast, Mar 12, 2012
  2. Junio C HamanoMar 12, 2012
  3. Thomas RastMar 12, 2012
  4. Junio C HamanoMar 12, 2012

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.