From: Thomas Rast <trast@inf.ethz.ch>
Date: Mon, 12 Mar 2012 20:13:22 GMT
Subject: Re: [PATCH] xdiff: load full words in the inner loop of xdl_hash_record
Message-ID: <877gypr319.fsf@thomas.inf.ethz.ch>
In-Reply-To: <7vmx7lsmjd.fsf@alter.siamese.dyndns.org>

Junio C Hamano <gitster@pobox.com> writes:

> Thomas Rast <trast@student.ethz.ch> writes:
>
>> Also definitely post-v1.7.10 material, but I figure many people will
>> be interested.  Since it's such a central part of much of git, it's
>> also quite important that it gets tested heavily.
>
> I am interested but this is a material not beyond 'pu'.  Until it
> learns to be nice on platforms that do not like unaligned accesses
> or use big endian, that is.

Umm, nice how?  It leaves in the old version for those platforms.  I can
perhaps make it #error if we are unhappy about the user's platform, but
that's about it.  Testing for endianness is possible, but testing for
unaligned access risks SIGBUS and thus requires spawning a helper
program.

-- 
Thomas Rast
trast@{inf,student}.ethz.ch