Re: [RFC PATCH] Revamp git-cherry(1)

From

Thomas Rast <tr@thomasrast.ch>

Date

Nov 21, 2013, 20:58 UTC

Message-ID

<874n754gkt.fsf@thomasrast.ch>

In-Reply-To

<20131121115423.GC7171@sigill.intra.peff.net>

Jeff King <peff@peff.net> writes:

> On Thu, Nov 21, 2013 at 12:30:56PM +0100, Thomas Rast wrote:
>
>> +Later, you can whether your changes have been applied by saying (still
>> +on `topic`):
>
> s/can/& see/ ?
>
>> +Note that this uses , and assumes that
>> +`core.autosetupmerge` is enabled (the default).
>
> I couldn't quite parse this. Is there a word missing before the comma,
> or is it "uses and assumes that..."?

Thanks for reading carefully.

> Given that it is the default, I wonder if it is worth mentioning at all.
> Even I, who knows what autosetupmerge does, took a minute to figure out
> why it is relevant here. I suspect it may just confuse most readers.

Ok, then let's remove it.

-- 
Thomas Rast
tr@thomasrast.ch