git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 1/1] builtin/receive-pack: avoid spinning no-op sideband async threads

From
Adrian Ratiu <adrian.ratiu@collabora.com>
Date
Mar 3, 2026, 12:47 UTC
Message-ID
<87342hoz9l.fsf@collabora.com>
In-Reply-To
<xmqq4imxzz90.fsf@gitster.g>
On Mon, 02 Mar 2026, Junio C Hamano <gitster@pobox.com> wrote:
Show 14 quoted lines
>> @@ -1674,6 +1680,9 @@ static void run_update_post_hook(struct command *commands)
>>  	int sideband_async_started = 0;
>>  	int saved_stderr = -1;
>>  
>> +	if (!hook_exists(the_repository, "post-update"))
>> +		return;
>> +
>>  	for (cmd = commands; cmd; cmd = cmd->next) {
>>  		if (cmd->error_string || cmd->did_not_exist)
>>  			continue;
>
> Ditto for "post-update".
>
> Will queue with the following change squashed in.
Thank you Junio, much appreciated!
Previous: Junio C HamanoNext: Patrick Steinhardt
Message 4 of 7 in “Fix update hook perf regression in next”
  1. 0/1 Fix update hook perf regression in nextAdrian Ratiu, Mar 2, 2026
  2. 1/1 builtin/receive-pack: avoid spinning no-op sideband async threadsAdrian Ratiu, Mar 2, 2026
  3. Junio C HamanoMar 2, 2026
  4. Adrian RatiuMar 3, 2026
  5. Patrick SteinhardtMar 3, 2026
  6. Adrian RatiuMar 3, 2026
  7. Jeff KingMar 3, 2026

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.