git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 0/1] Fix update hook perf regression in next

From
Adrian Ratiu <adrian.ratiu@collabora.com>
Date
Mar 2, 2026, 19:17 UTC
Message-ID
<20260302191704.1814567-1-adrian.ratiu@collabora.com>
Hello everyone,

This fixes a performance regression I introduced in next by removing the "exit early" check for hooks which output over a sideband, during the conversion to the new hook API.

That was unintentional and these hooks should continue to exit early if no hook is found, to avoid unnecessarily spinning un/down async threads which no-op and just add overhead.

Reported by Patrick at [1] and independently root caused and confirmed by Peff who fixed it in a very similar manner [2].

Pushed to GitHub [3] and succesfully ran the CI [4].

1: https://lore.kernel.org/git/aaWeSu-d1FMz_sW8@pks.im/T/#m4a1e62b3149825ef03f9b5b48f478933abc521cd 2: https://lore.kernel.org/git/aaWeSu-d1FMz_sW8@pks.im/T/#me0d2655bb53f5ca8fc8f31e5726ecf4d2971fa11 3: https://github.com/10ne1/git/tree/refs/heads/dev/aratiu/update-regression-fix 4: https://github.com/10ne1/git/actions/runs/22590151068

Adrian Ratiu (1):
  builtin/receive-pack: avoid spinning no-op sideband_async threads
 builtin/receive-pack.c | 12 ++++++++++++
 1 file changed, 12 insertions(+)
-- 
2.52.0.732.gb351b5166d.dirty
Next: Adrian Ratiu
Message 1 of 7 in “Fix update hook perf regression in next”
  1. 0/1 Fix update hook perf regression in nextAdrian Ratiu, Mar 2, 2026
  2. 1/1 builtin/receive-pack: avoid spinning no-op sideband async threadsAdrian Ratiu, Mar 2, 2026
  3. Junio C HamanoMar 2, 2026
  4. Adrian RatiuMar 3, 2026
  5. Patrick SteinhardtMar 3, 2026
  6. Adrian RatiuMar 3, 2026
  7. Jeff KingMar 3, 2026

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.