[PATCH] pre-commit.sample: don't use [...] around a tr range
- From
Jim Meyering <jim@meyering.net>
- Date
- Sep 21, 2009, 09:09 UTC
- Message-ID
- <871vm0k6jm.fsf@meyering.net>
Using square brackets in tr ranges is risky. From the documentation of GNU tr:
Ranges
The notation `M-N' expands to all of the characters from M through
N, in ascending order. M should collate before N; if it doesn't,
an error results. As an example, `0-9' is the same as
`0123456789'. GNU `tr' does not support the System V syntax that uses square
brackets to enclose ranges. Translations specified in that format
sometimes work as expected, since the brackets are often
transliterated to themselves. However, they should be avoided
because they sometimes behave unexpectedly. For example, `tr -d
'[0-9]'' deletes brackets as well as digits.However, if the use of [] is deliberate, because git still cares about portability to ancient SYSV versions of tr that require that notation, then let me know and I'll undo that part of the change and add a comment to that effect.
>From cd3c17c6a48c67d2a598001272f3283714b1df19 Mon Sep 17 00:00:00 2001
From: Jim Meyering <meyering@redhat.com> Date: Mon, 21 Sep 2009 10:58:02 +0200 Subject: [PATCH] pre-commit.sample: don't use [...] around a tr range
Using square brackets around a tr range is especially risky when using tr's -d (delete) option. In this case, the brackets happen to be harmless, since the two bracket bytes happen to be included in the desired range. Correct spelling and grammar.
Signed-off-by: Jim Meyering <meyering@redhat.com> --- templates/hooks--pre-commit.sample | 10 +++++----- 1 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/templates/hooks--pre-commit.sample b/templates/hooks--pre-commit.sample index b11ad6a..06a5afa 100755 --- a/templates/hooks--pre-commit.sample +++ b/templates/hooks--pre-commit.sample @@ -15,14 +15,14 @@ allownonascii=$(git config hooks.allownonascii) # printable range starts at the space character and ends with tilde. if [ "$allownonascii" != "true" ] && test "$(git diff --cached --name-only --diff-filter=A -z | - LC_ALL=C tr -d '[ -~]\0')" + LC_ALL=C tr -d ' -~\0')" then - echo "Error: Attempt to add a non-ascii filename." + echo "Error: Attempt to add a non-ascii file name." echo - echo "This can cause problems if you want to work together" - echo "with people on other platforms than you." + echo "This can cause problems if you want to work" + echo "with people on other platforms." echo - echo "To be portable it is adviseable to rename the file ..." + echo "To be portable it is advisable to rename the file ..." echo echo "If you know what you are doing you can disable this" echo "check using:" -- 1.6.5.rc1.214.g13c5a