Re: [PATCH] pre-commit.sample: don't use [...] around a tr range

From: Jeff King <peff@peff.net>
Date: Sep 24, 2009, 05:55 UTC
Message-ID: <20090924055518.GB24486@coredump.intra.peff.net>
In-Reply-To: <n2z47RdNjxVbPeRfgJuY54nJrfzDfn43bzv8HoH6cEuAzQ6fB1MaBg@cipher.nrlssc.navy.mil>

On Mon, Sep 21, 2009 at 10:58:51AM -0500, Brandon Casey wrote:

Show 15 quoted lines

> >> I had my doubts, but have just confirmed that Solaris 10's
> >> /usr/bin/tr is still doing it the SYSV way:
> >>
> >>     $ echo foo | LC_ALL=C /usr/bin/tr a-z A-Z
> >>     foo
> >>
> >> There, you have to use /usr/xpg4/bin/tr to get the expected behavior:
> >>
> >>     $ echo foo | LC_ALL=C /usr/xpg4/bin/tr a-z A-Z
> >>     FOO
> >>
> >> So you're right.  Thanks!
> 
> By the way, modern git inserts /usr/xpg4/bin into PATH before /usr/bin on
> Solaris.  So /usr/xpg4/bin/tr should always be used on that platform.

Ah, I forgot about that patch. So it may not matter on Solaris. Are there other platforms which want the brackets? Maybe HP-UX, but I no longer have access to a box and I've used deep hypnosis to suppress any memories of ever having used it.

Anyway, I think Jim's patch is the right fix if there are still platforms that want the brackets.

-Peff