git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] diff: add support for reading files literally with --no-index

From
Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Date
Dec 20, 2018, 21:43 UTC
Message-ID
<871s6bg9hx.fsf@evledraar.gmail.com>
In-Reply-To
<20181220002610.43832-1-sandals@crustytoothpaste.net>
On Thu, Dec 20 2018, brian m. carlson wrote:
> We don't include a test for the pipe scenario because I couldn't get
> that case to work in portable shell (although of course it works in
> bash). I have, however, tested it on both macOS and Linux. No clue how
> this works on Windows.

You can (and should) add tests using the PROCESS_SUBSTITUTION prereq Dennis used in an earlier version of this: https://public-inbox.org/git/20170113102021.6054-3-dennis@kaarsemaker.net/

Even if that wasn't possible a bash-specific test is better than no test, and can be had by including t/lib-bash.sh in your test, see e.g. the completion tests.

Previous: Duy NguyenNext: brian m. carlson
Message 9 of 18 in “diff: add support for reading files literally with --no-index”
  1. diff: add support for reading files literally with --no-indexbrian m. carlson, Dec 20, 2018
  2. Jeff KingDec 20, 2018
  3. brian m. carlsonDec 21, 2018
  4. Duy NguyenDec 20, 2018
  5. Jeff KingDec 20, 2018
  6. Duy NguyenDec 20, 2018
  7. Jeff KingDec 20, 2018
  8. Duy NguyenDec 20, 2018
  9. Ævar Arnfjörð BjarmasonDec 20, 2018
  10. brian m. carlsonDec 20, 2018
  11. Johannes SchindelinDec 21, 2018
  12. brian m. carlsonDec 21, 2018
  13. Junio C HamanoJan 2, 2019
  14. brian m. carlsonJan 4, 2019
  15. Jonathan NiederJan 4, 2019
  16. brian m. carlsonJan 4, 2019
  17. Junio C HamanoJan 4, 2019
  18. brian m. carlsonJan 5, 2019

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.