Re: [PATCH] diff: add support for reading files literally with --no-index
- From
brian m. carlson <sandals@crustytoothpaste.net>
- Date
- Dec 20, 2018, 23:54 UTC
- Message-ID
- <20181220235438.GE35965@genre.crustytoothpaste.net>
- In-Reply-To
- <871s6bg9hx.fsf@evledraar.gmail.com>
On Thu, Dec 20, 2018 at 10:43:06PM +0100, Ævar Arnfjörð Bjarmason wrote:
Show 11 quoted lines
> > On Thu, Dec 20 2018, brian m. carlson wrote: > > > We don't include a test for the pipe scenario because I couldn't get > > that case to work in portable shell (although of course it works in > > bash). I have, however, tested it on both macOS and Linux. No clue how > > this works on Windows. > > You can (and should) add tests using the PROCESS_SUBSTITUTION prereq > Dennis used in an earlier version of this: > https://public-inbox.org/git/20170113102021.6054-3-dennis@kaarsemaker.net/
I'm happy to steal that code. I didn't know this had come up before, so I didn't think of it.
-- brian m. carlson: Houston, Texas, US OpenPGP: https://keybase.io/bk2204