git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 4/5] p0004: don't abort if multi-threaded is too slow

From
René Scharfe <l.s.r@web.de>
Date
May 13, 2017, 16:03 UTC
Message-ID
<871f5f29-feb3-5c69-7ddd-f92819a76cce@web.de>
In-Reply-To
<9b574d73-8dfb-f0b3-dc3e-d593726a8f0e@web.de>

If the single-threaded variant beats the multi-threaded one then we may have a performance bug, but that doesn't justify aborting the test. Drop that check; we can compare the results for --single and --multi using the actual performance tests.

Signed-off-by: Rene Scharfe <l.s.r@web.de>
---
 t/perf/p0004-lazy-init-name-hash.sh | 4 ----
 1 file changed, 4 deletions(-)
diff --git a/t/perf/p0004-lazy-init-name-hash.sh b/t/perf/p0004-lazy-init-name-hash.sh
index d30c32f97b..3c2135a185 100755
--- a/t/perf/p0004-lazy-init-name-hash.sh
+++ b/t/perf/p0004-lazy-init-name-hash.sh
@@ -14,10 +14,6 @@ test_expect_success 'verify both methods build the same hashmaps' '
 	test_cmp sorted.single sorted.multi
 '
 
-test_expect_success 'multithreaded should be faster' '
-	test-lazy-init-name-hash --perf >out.perf
-'
-
 test_expect_success 'calibrate' '
 	entries=$(wc -l <out.single) &&
 
-- 
2.12.2
Previous: René ScharfeNext: René Scharfe
Message 5 of 7 in “p0004: support being called by t/perf/run”
  1. 0/5 p0004: support being called by t/perf/runRené Scharfe, May 13, 2017
  2. 1/5 p0004: simplify calls of test-lazy-init-name-hashRené Scharfe, May 13, 2017
  3. 2/5 p0004: avoid using pipesRené Scharfe, May 13, 2017
  4. 3/5 p0004: use test_perfRené Scharfe, May 13, 2017
  5. 4/5 p0004: don't abort if multi-threaded is too slowRené Scharfe, May 13, 2017
  6. 5/5 p0004: don't error out if test repo is too smallRené Scharfe, May 13, 2017
  7. Jeff HostetlerMay 15, 2017

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.