git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 1/5] p0004: simplify calls of test-lazy-init-name-hash

From
René Scharfe <l.s.r@web.de>
Date
May 13, 2017, 15:59 UTC
Message-ID
<02f4218d-857a-3615-cc3a-d03ecbf35e67@web.de>
In-Reply-To
<9b574d73-8dfb-f0b3-dc3e-d593726a8f0e@web.de>

The test library puts helpers into $PATH, so we can simply call them without specifying their location.

The suffix $X is also not necessary because .exe files on Windows can be started without specifying their extension, and on other platforms it's empty anyway.

Signed-off-by: Rene Scharfe <l.s.r@web.de>
---
 t/perf/p0004-lazy-init-name-hash.sh | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/t/perf/p0004-lazy-init-name-hash.sh b/t/perf/p0004-lazy-init-name-hash.sh
index 5afa8c8df3..716c951553 100755
--- a/t/perf/p0004-lazy-init-name-hash.sh
+++ b/t/perf/p0004-lazy-init-name-hash.sh
@@ -7,13 +7,13 @@ test_perf_large_repo
 test_checkout_worktree
 
 test_expect_success 'verify both methods build the same hashmaps' '
-	$GIT_BUILD_DIR/t/helper/test-lazy-init-name-hash$X --dump --single | sort >out.single &&
-	$GIT_BUILD_DIR/t/helper/test-lazy-init-name-hash$X --dump --multi  | sort >out.multi  &&
+	test-lazy-init-name-hash --dump --single | sort >out.single &&
+	test-lazy-init-name-hash --dump --multi  | sort >out.multi  &&
 	test_cmp out.single out.multi
 '
 
 test_expect_success 'multithreaded should be faster' '
-	$GIT_BUILD_DIR/t/helper/test-lazy-init-name-hash$X --perf >out.perf
+	test-lazy-init-name-hash --perf >out.perf
 '
 
 test_done
-- 
2.12.2
Previous: René ScharfeNext: René Scharfe
Message 2 of 7 in “p0004: support being called by t/perf/run”
  1. 0/5 p0004: support being called by t/perf/runRené Scharfe, May 13, 2017
  2. 1/5 p0004: simplify calls of test-lazy-init-name-hashRené Scharfe, May 13, 2017
  3. 2/5 p0004: avoid using pipesRené Scharfe, May 13, 2017
  4. 3/5 p0004: use test_perfRené Scharfe, May 13, 2017
  5. 4/5 p0004: don't abort if multi-threaded is too slowRené Scharfe, May 13, 2017
  6. 5/5 p0004: don't error out if test repo is too smallRené Scharfe, May 13, 2017
  7. Jeff HostetlerMay 15, 2017

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.