Re: git-rebase (1.5.0.6) errors

From: David Kastrup <dak@gnu.org>
Date: May 18, 2007, 10:49 UTC
Message-ID: <86y7jmmmnq.fsf@lola.quinscape.zz>
In-Reply-To: <34a7ae040705180331x1a86782fh3b2c6a87db32030e@mail.gmail.com>

"Paolo Teti" <paolo.teti@gmail.com> writes:

Show 17 quoted lines

> 2007/5/18, Ilpo Järvinen <ilpo.jarvinen@helsinki.fi>:
>> Hi,
>>
>>
>> ijjarvin@kivilampi-30:~/work/src/submit$ git-rebase net-2.6.22-origin
>> First, rewinding head to replay your work on top of it...
>> HEAD is now at d739437... [IPV4]: Correct rp_filter help text.
>> fatal: cannot convert from utf-8 to utf-8
>
>
> Now I can't test or try to reproduce your error,
> but looking at the source code (only with gitweb)
> I have found another bad use of size_t instead of ssize_t
> in the reencode_string(..) that take part at the conversion process.
>
> Using size_t in the next portion of code the check "count == -1" is
> never true.

Only if size_t is a larger type than int (could be on x86-64 and alpha architectures). Other than that, this comparison would work. Which does not mean that this does not warrant fixing, but it is not necessarily the cause of this problem.

Show 14 quoted lines

>
> while (1) {
> 		size_t cnt = iconv(conv, &cp, &insz, &outpos, &outsz);
>
> 		if (cnt == -1) {
> 			size_t sofar;
> 			if (errno != E2BIG) {
> 				free(out);
> 				iconv_close(conv);
> 				return NULL;
> 			}
>
>
> Please someone could fixes this bad use of size_t?..

-- 
David Kastrup