Re: git-rebase (1.5.0.6) errors

From: Paolo Teti <paolo.teti@gmail.com>
Date: May 18, 2007, 10:31 UTC
Message-ID: <34a7ae040705180331x1a86782fh3b2c6a87db32030e@mail.gmail.com>
In-Reply-To: <Pine.LNX.4.64.0705181130570.28356@kivilampi-30.cs.helsinki.fi>

2007/5/18, Ilpo Järvinen <ilpo.jarvinen@helsinki.fi>:

Show 7 quoted lines

> Hi,
>
>
> ijjarvin@kivilampi-30:~/work/src/submit$ git-rebase net-2.6.22-origin
> First, rewinding head to replay your work on top of it...
> HEAD is now at d739437... [IPV4]: Correct rp_filter help text.
> fatal: cannot convert from utf-8 to utf-8

Now I can't test or try to reproduce your error, but looking at the source code (only with gitweb) I have found another bad use of size_t instead of ssize_t in the reencode_string(..) that take part at the conversion process.

Using size_t in the next portion of code the check "count == -1" is never true.

while (1) {
		size_t cnt = iconv(conv, &cp, &insz, &outpos, &outsz);

		if (cnt == -1) {
			size_t sofar;
			if (errno != E2BIG) {
				free(out);
				iconv_close(conv);
				return NULL;
			}

Please someone could fixes this bad use of size_t?..

Sorry, but now I can't install/use git because I'm on a customer workstation..