git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v2] t4015: improve coverage of function context test

From
René Scharfe <l.s.r@web.de>
Date
Dec 19, 2019, 17:35 UTC
Message-ID
<86fbb0fd-6b77-5d11-69cd-f0994a8ed759@web.de>
In-Reply-To
<fedd48bd-28e8-ccc8-ae50-42d9b2ea1c16@web.de>

Add a test that includes an actual function line in the test file to check if context is expanded to include the whole function, and add an ignored change before function context to check if that one stays hidden while the originally ignored change within function context is shown.

Helped-by: Jeff King <peff@peff.net>
Signed-off-by: René Scharfe <l.s.r@web.de>
---
Changes:
* Keep existing test intact, add a new one instead.
* Use unique content for the part before the function context to make
  clear that it's independent.
 t/t4015-diff-whitespace.sh | 23 +++++++++++++++++++++++
 1 file changed, 23 insertions(+)
diff --git a/t/t4015-diff-whitespace.sh b/t/t4015-diff-whitespace.sh
index 65615e2fa9..88d3026894 100755
--- a/t/t4015-diff-whitespace.sh
+++ b/t/t4015-diff-whitespace.sh
@@ -2068,4 +2068,27 @@ test_expect_success 'combine --ignore-blank-lines with --function-context' '
 	test_cmp expect actual
 '

+test_expect_success 'combine --ignore-blank-lines with --function-context 2' '
+	test_write_lines    a b c "" function 1 2 3 4 5 "" 6 7 8 9 >a &&
+	test_write_lines "" a b c "" function 1 2 3 4 5    6 7 8   >b &&
+	test_must_fail git diff --no-index \
+		--ignore-blank-lines --function-context a b >actual.raw &&
+	sed -n "/@@/,\$p" <actual.raw >actual &&
+	cat <<-\EOF >expect &&
+	@@ -5,11 +6,9 @@ c
+	 function
+	 1
+	 2
+	 3
+	 4
+	 5
+	-
+	 6
+	 7
+	 8
+	-9
+	EOF
+	test_cmp expect actual
+'
+
 test_done
--
2.24.1
Previous: René ScharfeNext: Jeff King
Message 4 of 5 in “t4015: improve coverage of function context test”
  1. t4015: improve coverage of function context testRené Scharfe, Dec 18, 2019
  2. Jeff KingDec 18, 2019
  3. René ScharfeDec 19, 2019
  4. t4015: improve coverage of function context testRené Scharfe, Dec 19, 2019
  5. Jeff KingDec 19, 2019

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.