Re: [PATCH v2] t4015: improve coverage of function context test

From: Jeff King <peff@peff.net>
Date: Dec 19, 2019, 17:51 UTC
Message-ID: <20191219175115.GA677976@coredump.intra.peff.net>
In-Reply-To: <86fbb0fd-6b77-5d11-69cd-f0994a8ed759@web.de>

On Thu, Dec 19, 2019 at 06:35:43PM +0100, René Scharfe wrote:

Show 7 quoted lines

> Add a test that includes an actual function line in the test file to
> check if context is expanded to include the whole function, and add an
> ignored change before function context to check if that one stays hidden
> while the originally ignored change within function context is shown.
> 
> Helped-by: Jeff King <peff@peff.net>
> Signed-off-by: René Scharfe <l.s.r@web.de>

Thanks, the patch looks good.

Maybe worth noting in the commit message why there are two tests. Something like:

  This differs from the existing test, which is concerned with the case
  where there is no function line at all in the file (and we might look
  past the beginning of the file).

-Peff