Re: [BUG] daemon.c blows up on OSX
- From
Randal L. Schwartz <merlyn@stonehenge.com>
- Date
- Dec 20, 2006, 22:46 UTC
- Message-ID
- <86ac1iyyla.fsf@blue.stonehenge.com>
- In-Reply-To
- <86ejquyz4v.fsf@blue.stonehenge.com>
>>>>> "Randal" == Randal L Schwartz <merlyn@stonehenge.com> writes:
Randal> running "git version 1.4.4.3.g5485" on my openbsd box, but I can't get Randal> there on my OSX box.
According to my headers, "strncasecmp" is defined in <string.h>, "NI_MAXSERV" is defined in <netdb.h>, and "initgrps" is defined in "unistd.h". So this patch works (just verified on OSX), but I don't know what damage it does elsehwere:
diff --git a/daemon.c b/daemon.c index b129b83..5ce73ed 100644 --- a/daemon.c +++ b/daemon.c @@ -1,3 +1,7 @@ +#include <string.h> +#include <netdb.h> +#include <unistd.h> + #include "cache.h" #include "pkt-line.h" #include "exec_cmd.h" However, now imap-send.o blows up: imap-send.c: In function 'imap_open_store': imap-send.c:908: error: 'AF_LOCAL' undeclared (first use in this function) imap-send.c:908: error: (Each undeclared identifier is reported only once imap-send.c:908: error: for each function it appears in.) imap-send.c:990: warning: implicit declaration of function 'getpass' imap-send.c:990: warning: assignment makes pointer from integer without a cast make: *** [imap-send.o] Error 1 and finding "getpass" wants me to add "unistd.h" there too. Hmm. Let's see if I can use git-format-patch as Linus intended. From 1549561dc68a1ea71f137c40109c90d33c0f9887 Mon Sep 17 00:00:00 2001 From: Randal L. Schwartz <merlyn@4.sub-70-192-166.myvzw.com> Date: Wed, 20 Dec 2006 14:45:49 -0800 Subject: [PATCH] patch for osx --- daemon.c | 4 ++++ imap-send.c | 2 ++ 2 files changed, 6 insertions(+), 0 deletions(-) diff --git a/daemon.c b/daemon.c index b129b83..5ce73ed 100644 --- a/daemon.c +++ b/daemon.c @@ -1,3 +1,7 @@ +#include <string.h> +#include <netdb.h> +#include <unistd.h> + #include "cache.h" #include "pkt-line.h" #include "exec_cmd.h" diff --git a/imap-send.c b/imap-send.c index 894cbbd..afd7447 100644 --- a/imap-send.c +++ b/imap-send.c @@ -22,6 +22,8 @@ * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA */ +#include <unistd.h> + #include "cache.h" typedef struct store_conf {
-- 1.4.4.3.g5485-dirty -- Randal L. Schwartz - Stonehenge Consulting Services, Inc. - +1 503 777 0095 <merlyn@stonehenge.com> <URL:http://www.stonehenge.com/merlyn/> Perl/Unix/security consulting, Technical writing, Comedy, etc. etc. See PerlTraining.Stonehenge.com for onsite and open-enrollment Perl training!