Re: [BUG] daemon.c blows up on OSX

From: Junio C Hamano <junkio@cox.net>
Date: Dec 20, 2006, 23:30 UTC
Message-ID: <7v64c65emt.fsf@assigned-by-dhcp.cox.net>
In-Reply-To: <86wt4mximh.fsf@blue.stonehenge.com>

merlyn@stonehenge.com (Randal L. Schwartz) writes:

Show 8 quoted lines

> But yes, _XOPEN_SOURCE_EXTENDED definitely does some damage to
> curses.h.  However, I don't see how that's relevant to strings.h
> or the others I need.  There's no "config" for "compatibility".
> Welcome to Linux vs Unix. :)
>
> What I do know is (a) it worked before the header changes and (b)
> the patch I just gave you works.  If the patch doesn't break others,
> can we just leave it in?

That would lead to maintenance nightmare in the longer term. We cannot do that unless we know more or less what is going on. Including only some system headers in a random order before feature macros are defined, and doing so in only some source files randomly until it starts compiling, is not a solution maintainable in the longer term.

The _EXTENDED stuff is minimally commented that AIX wants it; otherwise we would have been tempted to say, "remove it, if it breaks OSX" without thinking, and would have ended up breaking AIX.

No matter what we do, I would really want a clear description of in what way OSX headers are broken and what needs to be done to avoid the breakage in git-compat-util.h where it sets up feature macros and includes system headers.