Re: [PATCH] git-send-email.perl: Really add angle brackets to In-Reply-To if necessary

From: Randal L. Schwartz <merlyn@stonehenge.com>
Date: Dec 9, 2007, 18:53 UTC
Message-ID: <86aboju2bp.fsf@blue.stonehenge.com>
In-Reply-To: <851w9vsp8o.fsf@lola.goethe.zz>

>>>>> "David" == David Kastrup <dak@gnu.org> writes:

Show 7 quoted lines

>>> $initial_reply_to = $_;
>>> -	$initial_reply_to =~ s/^\s+<?/</;
>>> -	$initial_reply_to =~ s/>?\s+$/>/;
>>> }
>> 
>> I wonder what the original rationale for these \s+ was.
>> Will apply, anyway.  Thanks.

David> The original line read

David> 	$initial_reply_to =~ s/(^\s+|\s+$)//g;

David> and was used just for stripping spaces (no stripping necessary when David> there is no space, so \s+ was ok). The change was supposed to work David> on the brackets, too.

David> That Mike got bitten here is proof that the original idea had merit. David> Too bad the implementation did not actually work.

I think what you were trying to do would work with:

  for ($initial_reply_to) {
      s/^\s*<?/</;
      s/>?\s*$/>/;
  }

Untested, but I get this stuff right most of the time. :)

-- 
Randal L. Schwartz - Stonehenge Consulting Services, Inc. - +1 503 777 0095
<merlyn@stonehenge.com> <URL:http://www.stonehenge.com/merlyn/>
Perl/Unix/security consulting, Technical writing, Comedy, etc. etc.
See PerlTraining.Stonehenge.com for onsite and open-enrollment Perl training!