Re: [PATCH] git-send-email.perl: Really add angle brackets to In-Reply-To if necessary

From: Junio C Hamano <gitster@pobox.com>
Date: Dec 9, 2007, 18:09 UTC
Message-ID: <7v63z7rb87.fsf@gitster.siamese.dyndns.org>
In-Reply-To: <1197220648-20433-1-git-send-email-mh@glandium.org>

Mike Hommey <mh@glandium.org> writes:

Show 8 quoted lines

> 3803bcea tried to fix this, but it only adds the branckes when the given
> In-Reply-To begins and ends with whitespaces. It also didn't do anything
> to the --in-reply-to argument.
>
> Signed-off-by: Mike Hommey <mh@glandium.org>
> ---
>
> I just got bitten by this...

Interesting.

Show 15 quoted lines

>
>  git-send-email.perl |    5 +++--
>  1 files changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/git-send-email.perl b/git-send-email.perl
> index 76baa8e..1434eb2 100755
> --- a/git-send-email.perl
> +++ b/git-send-email.perl
> @@ -367,10 +367,11 @@ if ($thread && !defined $initial_reply_to && $prompting) {
>  	} while (!defined $_);
>  
>  	$initial_reply_to = $_;
> -	$initial_reply_to =~ s/^\s+<?/</;
> -	$initial_reply_to =~ s/>?\s+$/>/;
>  }

I wonder what the original rationale for these \s+ was. Will apply, anyway. Thanks.

Show 9 quoted lines

>  
> +$initial_reply_to =~ s/^\s*\<?/\</;
> +$initial_reply_to =~ s/>?\s*$/>/;
> +
>  if (!defined $smtp_server) {
>  	foreach (qw( /usr/sbin/sendmail /usr/lib/sendmail )) {
>  		if (-x $_) {
> -- 
> 1.5.3.7