git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v2 2/2] gitk: rename "commit summary" to "commit reference"

From
Denton Liu <liu.denton@gmail.com>
Date
Dec 13, 2019, 00:44 UTC
Message-ID
<8691ed2b84f7ee6b7c12d04d57a541bf22660333.1576197846.git.liu.denton@gmail.com>
In-Reply-To
<cover.1576197846.git.liu.denton@gmail.com>
From: Beat Bolli <dev+git@drbeat.li>

Now that the commit reference format has a canonical name, let's use this name in gitk's UI and implementation.

Signed-off-by: Beat Bolli <dev+git@drbeat.li>
[dl: based the patch on gitk's tree]
Signed-off-by: Denton Liu <liu.denton@gmail.com>
---
 gitk | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/gitk b/gitk
index d07e3302de..17346b4c5c 100755
--- a/gitk
+++ b/gitk
@@ -2640,7 +2640,7 @@ proc makewindow {} {
 	{mc "Diff selected -> this" command {diffvssel 1}}
 	{mc "Make patch" command mkpatch}
 	{mc "Create tag" command mktag}
-	{mc "Copy commit summary" command copysummary}
+	{mc "Copy commit reference" command copyreference}
 	{mc "Write commit to file" command writecommit}
 	{mc "Create new branch" command mkbranch}
 	{mc "Cherry-pick this commit" command cherrypick}
@@ -9426,7 +9426,7 @@ proc mktaggo {} {
     mktagcan
 }
 
-proc copysummary {} {
+proc copyreference {} {
     global rowmenuid autosellen
 
     set format "%h (%s, %ad)"
@@ -9434,10 +9434,10 @@ proc copysummary {} {
     if {$autosellen < 40} {
         lappend cmd --abbrev=$autosellen
     }
-    set summary [eval exec $cmd $rowmenuid]
+    set reference [eval exec $cmd $rowmenuid]
 
     clipboard clear
-    clipboard append $summary
+    clipboard append $reference
 }
 
 proc writecommit {} {
-- 
2.24.1.664.g198078bb5a
Previous: Paul MackerrasNext: Junio C Hamano
Message 8 of 11 in “gitk: use --pretty=reference for copysummary”
  1. gitk: use --pretty=reference for copysummaryDenton Liu, Dec 11, 2019
  2. Paul MackerrasDec 11, 2019
  3. Junio C HamanoDec 11, 2019
  4. 0/2 gitk: match Git's 'reference' pretty formatDenton Liu, Dec 13, 2019
  5. 1/2 gitk: drop quotes in copysummary formatDenton Liu, Dec 13, 2019
  6. Junio C HamanoDec 13, 2019
  7. Paul MackerrasDec 15, 2019
  8. 2/2 gitk: rename "commit summary" to "commit reference"Denton Liu, Dec 13, 2019
  9. Junio C HamanoDec 13, 2019
  10. Paul MackerrasDec 15, 2019
  11. Junio C HamanoDec 13, 2019

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.