git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] gitk: use --pretty=reference for copysummary

From
Paul Mackerras <paulus@ozlabs.org>
Date
Dec 11, 2019, 21:58 UTC
Message-ID
<20191211215826.GA31614@blackberry>
In-Reply-To
<da9321b1bd56aafd16c8dcb99d5d628b79e2244e.1576100147.git.liu.denton@gmail.com>
On Wed, Dec 11, 2019 at 01:39:50PM -0800, Denton Liu wrote:
Show 12 quoted lines
> In an earlier commit[1], git learned the 'reference' pretty format.
> Update copysummary to use this pretty format instead of manually
> reimplementing it as a format string.
> 
> With this change, we lose the double-quotes surrounding the commit
> subject but it seems the consensus is that the unquoted form is used
> more often anyway[2] so this change should be acceptable.
> 
> Since gitk and git are usually packaged and distributed together, their
> versions should be in sync so we should not have to worry a newer gitk
> running on top of an older version of git that doesn't support the
> 'reference' pretty format.

In fact my policy is not to do this (introduce a change to gitk that means it requires the very latest git). I would want the code either to test the git version (which the code already does in other places) or handle failure gracefully and fall back to the old command.

Paul.
Previous: Denton LiuNext: Junio C Hamano
Message 2 of 11 in “gitk: use --pretty=reference for copysummary”
  1. gitk: use --pretty=reference for copysummaryDenton Liu, Dec 11, 2019
  2. Paul MackerrasDec 11, 2019
  3. Junio C HamanoDec 11, 2019
  4. 0/2 gitk: match Git's 'reference' pretty formatDenton Liu, Dec 13, 2019
  5. 1/2 gitk: drop quotes in copysummary formatDenton Liu, Dec 13, 2019
  6. Junio C HamanoDec 13, 2019
  7. Paul MackerrasDec 15, 2019
  8. 2/2 gitk: rename "commit summary" to "commit reference"Denton Liu, Dec 13, 2019
  9. Junio C HamanoDec 13, 2019
  10. Paul MackerrasDec 15, 2019
  11. Junio C HamanoDec 13, 2019

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.