Re: [GUILT PATCH 2/5] guilt-guard: Assign guards to patches in series

From: David Kastrup <dak@gnu.org>
Date: Aug 9, 2007, 08:43 UTC
Message-ID: <868x8lnlml.fsf@lola.quinscape.zz>
In-Reply-To: <18071eea0708090122h79dec205j4528f4dfd7aab588@mail.gmail.com>

"Thomas Adam" <thomas.adam22@gmail.com> writes:

Show 6 quoted lines

> On 09/08/07, David Kastrup <dak@gnu.org> wrote:
>>     sed -i -e "s,^\($p[[:space:]]*.*\)\$,\1 #$x," "$series"
>>
>> and that's fine.
>
> I'm surprised to see 'sed -i' being at all, it's certainly non-portable.

Yes. Neither is [[:space:]]. The above actually is pretty much equivalent to

      $(RM) "$series+"
      sed "/^$p/s/\$/ #$x/" "$series" >"$series+"
      $(MV) "$series+" "$series"

Which is probably not what was intended (the whole [[:space:]] construct is irrelevant). More likely it was intended to do something like

      $(RM) "$series+"
      sed "/^$p[ 	]/s/\$/ #$x/" "$series" >"$series+"
      $(MV) "$series+" "$series"

or if $p can contain slashes but not commata,

      $(RM) "$series+"
      sed "\,^$p[ 	],s,\$, #$x," "$series" >"$series+"
      $(MV) "$series+" "$series"

Note that the included tab character will get safely from any shell to any sed.

-- 
David Kastrup