Re: [GUILT PATCH 2/5] guilt-guard: Assign guards to patches in series
- From
- Josef Sipek <jsipek@fsl.cs.sunysb.edu>
- Date
- Aug 9, 2007, 13:47 UTC
- Message-ID
- <20070809134715.GA22563@filer.fsl.cs.sunysb.edu>
- In-Reply-To
- <87bqdhnotj.fsf@hubert.paunchy.net>
On Thu, Aug 09, 2007 at 12:34:48AM -0700, Eric Lesh wrote:
> [ I'm finally back to this. Thanks for your comments. ]
Good. I was starting to get worried :)
Show 16 quoted lines
> Josef Sipek <jsipek@fsl.cs.sunysb.edu> writes:
>
> [...]
>
> >> +}
> >> +
> >> +# usage: set_guards <patch> <guards...>
> >> +set_guards()
> >> +{
> >> + p="$1"
> >
> > Again, be careful about namespace polution.
> >
>
> Can I use "local", or is it a bashism? If not, use parentheses around
> the function body?Right, "local" is a bashism therefore you must use a subshell (paretheses).
Show 9 quoted lines
> >> + shift > >> + for x in "$@"; do > >> + if [ -z $(printf %s "$x" | grep -e "^[+-]") ]; then > > > > Out of curiosity, why printf and not echo? > > > > For guards named '-e' or other funky things echo doesn't like and can't > process with echo --.
Good enough reason :)
...
> I'm trying to clean the rest and get it ready again. This whole series > will definitely need to incubate for a while once there's a > reasonable-looking version, to make sure nothing goes crazy. Hopefully > it ends up being useful somewhere!
I'd use it at times. For certain scenarios (2 series that are mostly identical) using guards makes more sense than different branches.
Thanks,
Josef 'Jeff' Sipek.
-- Humans were created by water to transport it upward.