Re: [PATCH 7/8] commit-graph: not compatible with uninitialized repo

From: Jakub Narebski <jnareb@gmail.com>
Date: Jul 29, 2018, 22:46 UTC
Message-ID: <86600x7j9e.fsf@gmail.com>
In-Reply-To: <5314a5a93dfc224edd995fa12d195087c4685208.1531926932.git.gitgitgadget@gmail.com>

"Derrick Stolee via GitGitGadget" <gitgitgadget@gmail.com> writes:

[I hope that the rest of replies would make it all right through GitGitGadget]

Show 18 quoted lines

> From: Derrick Stolee <dstolee@microsoft.com>
>
> Signed-off-by: Derrick Stolee <dstolee@microsoft.com>
> ---
>  commit-graph.c | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/commit-graph.c b/commit-graph.c
> index 5097c7c12..233958e10 100644
> --- a/commit-graph.c
> +++ b/commit-graph.c
> @@ -60,6 +60,9 @@ static struct commit_graph *alloc_commit_graph(void)
>  
>  static int commit_graph_compatible(struct repository *r)
>  {
> +	if (!r->gitdir)
> +		return 0;
> +

Nice catch.

I wonder if this is the problem because of the following tests (in which case this test should probably be earlier in this series), or not (and it doesn't need to).

I wonder how this issue was caught.

>  	prepare_commit_graft(r);
>  	if (r->parsed_objects && r->parsed_objects->grafts_nr)
>  		return 0;

No tests?