Re: [PATCH 5/8] commit-graph: not compatible with replace objects
- From
Jeff King <peff@peff.net>
- Date
- Jul 18, 2018, 19:48 UTC
- Message-ID
- <20180718194846.GD7778@sigill.intra.peff.net>
- In-Reply-To
- <20180718194657.GC7778@sigill.intra.peff.net>
On Wed, Jul 18, 2018 at 03:46:57PM -0400, Jeff King wrote:
Show 12 quoted lines
> On Wed, Jul 18, 2018 at 08:15:41AM -0700, Derrick Stolee via GitGitGadget wrote: > > > From: Derrick Stolee <dstolee@microsoft.com> > > > > Create new method commit_graph_compatible(r) to check if a given > > repository r is compatible with the commit-graph feature. Fill the > > method with a check to see if replace-objects exist. Test this > > interaction succeeds, including ignoring an existing commit-graph and > > failing to write a new commit-graph. > > I think this approach is sensible. These are optimizations, and it's not > a big deal to just punt no cases we can't handle.
Er, this should be "punt _on_ cases we can't handle". Sorry for my belated proof-reading.
-Peff