Re: [PATCH] Convert open("-|") to qx{} calls
- From
Randal L. Schwartz <merlyn@stonehenge.com>
- Date
- Feb 23, 2006, 18:42 UTC
- Message-ID
- <863bi9hq6u.fsf@blue.stonehenge.com>
- In-Reply-To
- <7v1wxuhsgw.fsf@assigned-by-dhcp.cox.net>
>>>>> "Junio" == Junio C Hamano <junkio@cox.net> writes:
Junio> The version of Perl Alex has to use claims to be 5.8, but does Junio> not understand open($kid, '-|'), and he is trying to come up Junio> with a workaround.
Ahh, the problem is activestate then. If that's the case, then amend the code with a check for $^O (operating system) that falls back to a qx if on activestate, and hope that filenames aren't a problem. Unfortunately, I don't know enough about that to fix it.
But whatever you do, *don't* replace safe_qx with qx() for all other systems, or you'll be opening up a can of worms for those of us on sensible systems.
-- Randal L. Schwartz - Stonehenge Consulting Services, Inc. - +1 503 777 0095 <merlyn@stonehenge.com> <URL:http://www.stonehenge.com/merlyn/> Perl/Unix/security consulting, Technical writing, Comedy, etc. etc. See PerlTraining.Stonehenge.com for onsite and open-enrollment Perl training!