Re: [PATCH] Convert open("-|") to qx{} calls
- From
Junio C Hamano <junkio@cox.net>
- Date
- Feb 23, 2006, 17:53 UTC
- Message-ID
- <7v1wxuhsgw.fsf@assigned-by-dhcp.cox.net>
- In-Reply-To
- <86hd6qgit5.fsf@blue.stonehenge.com>
merlyn@stonehenge.com (Randal L. Schwartz) writes:
Show 5 quoted lines
> Convert all of these to use "safe_qx" (perl 5.6 compatible):
>
> sub safe_qx {
> defined (my $pid = open my $kid, "-|") or die "Cannot fork: $!";
>...IIRC, that is backwards. The thread's conversion is not about 5.6 vs 5.8. The conversion like what you suggested above was done, but the thing is, and Alex's Perl is unhappy about it.
The version of Perl Alex has to use claims to be 5.8, but does not understand open($kid, '-|'), and he is trying to come up with a workaround.
I wish Perl had a stricter trademark policy that required language features to be fully ported for an implementation to use that name ;-).