Re: [PATCH 1/5] engine.pl: Fix i18n -o option in msvc buildsystem generator

From: Philip Oakley <philipoakley@iee.org>
Date: Dec 26, 2014, 12:06 UTC
Message-ID: <862FFBB15AC74BD9AB675310958C6715@PhilipOakley>
In-Reply-To: <1419418034-6276-2-git-send-email-philipoakley@iee.org>

From: "Philip Oakley" <philipoakley@iee.org>

Show 8 quoted lines

> The i18n 5e9637c (i18n: add infrastructure for translating
> Git with gettext, 2011-11-18) introduced an extra '-o' option
> into the make file, which broke engine.pl code for extracting
> the git.sln for msvc gui-IDE.
>
> Add tests to remove these non linker options, in same vein as
> 74cf9bd (engine.pl: Fix a recent breakage of the buildsystem
> generator, 2010-01-22).

It now looks like this resolution is in the wrong direction. The
correct right solution is to include
    NO_GETTEXT = YesPlease
into the _Windows_ section of the Makefile.

Mysgit uses the _MinGW_ section, and fixed the NO_GETTEXT requirement, so the breakage in the Windows section build wasn't noticed.

However, the test is still useful for adding a detection step and 
providing a warning to users
    NO_GETTEXT = YesPlease

Show 26 quoted lines

>
> Signed-off-by: Philip Oakley <philipoakley@iee.org>
> ---
> contrib/buildsystems/engine.pl | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/contrib/buildsystems/engine.pl 
> b/contrib/buildsystems/engine.pl
> index 23da787..f48c28a 100755
> --- a/contrib/buildsystems/engine.pl
> +++ b/contrib/buildsystems/engine.pl
> @@ -140,6 +140,12 @@ sub parseMakeOutput
>             next;
>         }
>
> +        if ($text =~ /^(mkdir|msgfmt) /) {
> +            # options to the Portable Object translations
> +            # the line "mkdir ... && msgfmt ..." contains no linker 
> options
> +            next;
> +        }
> +
>         if($text =~ / -c /) {
>             # compilation
>             handleCompileLine($text, $line);
> --

There are still more issues to be resolved e.g.
  test-svn-fe.obj : error LNK2001: unresolved external symbol _strtoull
 etc.
Philip

-- 
-- 
*** Please reply-to-all at all times ***
*** (do not pretend to know who is subscribed and who is not) ***
*** Please avoid top-posting. ***
The msysGit Wiki is here: https://github.com/msysgit/msysgit/wiki - Github accounts are free.

You received this message because you are subscribed to the Google
Groups "msysGit" group.
To post to this group, send email to msysgit@googlegroups.com
To unsubscribe from this group, send email to
msysgit+unsubscribe@googlegroups.com
For more options, and view previous threads, visit this group at
http://groups.google.com/group/msysgit?hl=en_US?hl=en

--- 
You received this message because you are subscribed to the Google Groups "Git for Windows" group.
To unsubscribe from this group and stop receiving emails from it, send an email to msysgit+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.