git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 1/5] engine.pl: Fix i18n -o option in msvc buildsystem generator

From
Philip Oakley <philipoakley@iee.org>
Date
Dec 24, 2014, 10:47 UTC
Message-ID
<1419418034-6276-2-git-send-email-philipoakley@iee.org>
In-Reply-To
<1419418034-6276-1-git-send-email-philipoakley@iee.org>

The i18n 5e9637c (i18n: add infrastructure for translating Git with gettext, 2011-11-18) introduced an extra '-o' option into the make file, which broke engine.pl code for extracting the git.sln for msvc gui-IDE.

Add tests to remove these non linker options, in same vein as 74cf9bd (engine.pl: Fix a recent breakage of the buildsystem generator, 2010-01-22).

Signed-off-by: Philip Oakley <philipoakley@iee.org>
---
 contrib/buildsystems/engine.pl | 6 ++++++
 1 file changed, 6 insertions(+)
diff --git a/contrib/buildsystems/engine.pl b/contrib/buildsystems/engine.pl
index 23da787..f48c28a 100755
--- a/contrib/buildsystems/engine.pl
+++ b/contrib/buildsystems/engine.pl
@@ -140,6 +140,12 @@ sub parseMakeOutput
             next;
         }
 
+        if ($text =~ /^(mkdir|msgfmt) /) {
+            # options to the Portable Object translations
+            # the line "mkdir ... && msgfmt ..." contains no linker options
+            next;
+        }
+
         if($text =~ / -c /) {
             # compilation
             handleCompileLine($text, $line);
-- 
2.1.0
Previous: Philip OakleyNext: Philip Oakley
Message 2 of 8 in “Fix the Visual Studio 2008 .sln generator”
  1. 0/5 Fix the Visual Studio 2008 .sln generatorPhilip Oakley, Dec 24, 2014
  2. 1/5 engine.pl: Fix i18n -o option in msvc buildsystem generatorPhilip Oakley, Dec 24, 2014
  3. Philip OakleyDec 26, 2014
  4. 2/5 engine.pl: Properly accept quoted spaces in filenamesPhilip Oakley, Dec 24, 2014
  5. 3/5 engine.pl: ignore invalidcontinue.obj which is known to MSVCPhilip Oakley, Dec 24, 2014
  6. 4/5 vcbuild/readme: Improve layout and reference msvc-build scriptPhilip Oakley, Dec 24, 2014
  7. 5/5 engine.pl: provide more debug print statementsPhilip Oakley, Dec 24, 2014
  8. Philip OakleyDec 26, 2014

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.