Re: [PATCH] vc-git: support asynchronous annotations, and improve versioning.

From: David Kastrup <dak@gnu.org>
Date: Jul 16, 2007, 05:29 UTC
Message-ID: <85k5t0or0d.fsf@lola.goethe.zz>
In-Reply-To: <7v3azpavae.fsf@assigned-by-dhcp.cox.net>

Junio C Hamano <gitster@pobox.com> writes:

Show 13 quoted lines

> David Kastrup <dak@gnu.org> writes:
>
>> (vc-git-symbolic-commit): Allow nil to pass through.
>> (vc-git-previous-version): Use explicit parent argument.
>> (vc-git-next-version): Simplify.
>> (vc-git-annotate-command): Use `vc-do-command'.
>> (vc-git-annotate-extract-revision-at-line): Rename from
>> `vc-annotate-extract-revision-at-line'.
>> (vc-git-checkout): Make nicer way of ensuring encoding.
>>
>
> These do not seem to match what the patch does at all.
> I give up.

The previous changelog entry crept in as well.

> Will apply only the "install .el, too" change from the confusing
> series for now.

Fair enough.

How do I go about resubmitting with better comments? Make an extra branch and redo the part in artificial new commits?

I have no experience. Any good pointers how one does this sort of propose, rewind, propose stuff most conveniently?

-- 
David Kastrup, Kriemhildstr. 15, 44793 Bochum