Re: [PATCH] contrib/emacs/vc-git.el: various improvements.

David Kastrup <dak@gnu.org> writes:

It would be easier to review and understand if "something useful" were more specific.

It appears that the previous version of this function tried not to barf if it got nil or false as input but now it does not seem to worry about that case. Also the option given to name-rev is different which would lead to different behaviour -- arguably a better one, but that needs to be documented in the log message.

If you make the result symbolic using vc-git-symbolic-commit, do you need to add --abbrev/--abbrev-commit to these functions? These options have very small but still non zero cost.

Ok.